Adapt tests for internationalization

[Hofer-Julian]

I've noticed that two tests fail on my system when running toolkit check pr. The reason for this is that my locale is set to German. ls is translated, so checking the error message will only work on systems set to English.

I've adapted the test to check the exit code instead.

Alternatively, we could set the locale, I am not sure if the nu! macro supports that though.

[fdncred]

There is a locale override

nushell/toolkit.nu

Line 254 in ff5815c

$env.NU_TEST_LOCALE_OVERRIDE = 'en_US.utf8';

It also looks like some tests support locale

https://github.com/nushell/nushell/blob/ff5815c0a305477ec37cb738938430a17a408782/crates/nu-command/tests/commands/date/format.rs#L22-L83

nushell/crates/nu-command/tests/commands/str_/into_string.rs

Lines 151 to 192 in ff5815c

	#[test]
	fn int_into_string_decimals_0() {
	let actual = nu!(
	locale: "en_US.UTF-8",
	pipeline(
	r#"
	10 | into string --decimals 0
	"#
	)
	);
	assert_eq!(actual.out, "10");
	}
	#[test]
	fn int_into_string_decimals_1() {
	let actual = nu!(
	locale: "en_US.UTF-8",
	pipeline(
	r#"
	10 | into string --decimals 1
	"#
	)
	);
	assert_eq!(actual.out, "10.0");
	}
	#[test]
	fn int_into_string_decimals_10() {
	let actual = nu!(
	locale: "en_US.UTF-8",
	pipeline(
	r#"
	10 | into string --decimals 10
	"#
	)
	);
	assert_eq!(actual.out, "10.0000000000");
	}

and a function with_locale_override in our nu-test-support crate
https://github.com/nushell/nushell/blob/ff5815c0a305477ec37cb738938430a17a408782/crates/nu-test-support/src/locale_override.rs#L9-L40

[Hofer-Julian]

@fdncred As far as I can tell, neither of them influence the output of an external command like ^ls

I also tried adding

$env.LANG = 'en_US.UTF-8'
$env.LANGUAGE = 'en'

But it still doesn't seem to stop ls from outputting German

[Hofer-Julian]

But it still doesn't seem to stop ls from outputting German

Correction, that does work. I just had to import the adapted version of toolkit.nu.

I adapted the PR accordingly.

[fdncred]

Right. I wasn't saying ls supports it. I was saying that people have implemented some locale things in testing. So, if we want to do that with ls, someone would need to make ls aware of these locale settings. I believe ls is aware of locale as it understands decimals and commas for numbers but that may be handled somewhere closer to table rendering.

[Hofer-Julian]

I believe ls is aware of locale as it understands decimals and commas for numbers but that may be handled somewhere closer to table rendering

Indeed. External ls (not nushell's ls) reads env vars which I've adapted in the updated version of this PR.

[fdncred]

thanks