Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add $.extra_usage to modules #11649

Merged
merged 2 commits into from Jan 27, 2024
Merged

Conversation

amtoine
Copy link
Member

@amtoine amtoine commented Jan 27, 2024

Description

this PR

  • adds a test that should pass but fails
  • adds $.extra_usage to the output of scope modules, fixing both the new test and the linked issue

User-Facing Changes

$.extra_usage is now a column in the output of scope modules

Tests + Formatting

a new test case has been added to correct_scope_modules_fields

After Submitting

@amtoine amtoine requested a review from kubouch January 27, 2024 12:28
@kubouch
Copy link
Contributor

kubouch commented Jan 27, 2024

Thanks!

@kubouch kubouch merged commit 859f7b3 into nushell:main Jan 27, 2024
19 checks passed
@amtoine amtoine deleted the add-extra-usage-to-modules branch January 28, 2024 08:44
@hustcer hustcer added this to the v0.90.0 milestone Feb 3, 2024
dmatos2012 pushed a commit to dmatos2012/nushell that referenced this pull request Feb 20, 2024
- should fix nushell#11648

# Description
this PR
- adds a test that should pass but fails
- adds `$.extra_usage` to the output of `scope modules`, fixing both the
new test and the linked issue

# User-Facing Changes
`$.extra_usage` is now a column in the output of `scope modules`

# Tests + Formatting
a new test case has been added to `correct_scope_modules_fields`

# After Submitting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

modules don't have "extra usage" but commands do
3 participants