Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #11750: LazyRecord error message #11772

Merged
merged 2 commits into from Feb 7, 2024

Conversation

IanManske
Copy link
Member

@IanManske IanManske commented Feb 6, 2024

Description

Makes LazyRecords have the same error message as regular Records for Value::follow_cell_path. Fixes #11750.

@fdncred
Copy link
Collaborator

fdncred commented Feb 6, 2024

Thanks for cleaning this up.

@WindSoilder WindSoilder merged commit 857c522 into nushell:main Feb 7, 2024
19 checks passed
@fdncred fdncred added the pr:errors This PR improves our error messages label Feb 7, 2024
@fdncred fdncred added this to the v0.91.0 milestone Feb 7, 2024
dmatos2012 pushed a commit to dmatos2012/nushell that referenced this pull request Feb 20, 2024
# Description
Makes `LazyRecord`s have the same error message as regular `Records` for
`Value::follow_cell_path`. Fixes nushell#11750.
@IanManske IanManske deleted the lazy-record-cell-path branch March 5, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:errors This PR improves our error messages wait-until-after-nushell-release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confusing error for a lazy record
3 participants