Have internal/external/pipelines taken an optional InputStream. #1182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Primarily, this fixes an issue where we always open a stdin pipe for external commands, which can break various interactive commands (e.g., editors).
|
|
thegedge
commented
Jan 10, 2020
|
Let's land this. I think it's a good incremental improvement from where we are. Something I'd like to explore is if we want to push the Option deeper to the commands themselves. I mentioned in the comment we probably want the type checker to check for this, but until then, commands should probably be aware of how they're being run and if they actually have input. If they expect input, and don't get it, they could give a better error than we give today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1173
Stdin pipes are no longer opened for the first external command in a pipeline. I think it also makes far more sense than
InputStream::Emptyas the starting point for a pipeline.I was trying to think of how I could write a test to capture this, but nothing came to mind.