Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FreeBSD compatibility patches #11869

Merged
merged 2 commits into from Feb 17, 2024
Merged

Conversation

yurivict
Copy link
Contributor

@yurivict yurivict commented Feb 16, 2024

Description

nushell is verified to work on FreeBSD 14 with these patches.

What isn't supported on FreeBSD:

  • the crate 'procfs' doesn't support FreeBSD yet, all functionality depending on procfs is disabled
  • several RLIMIT_* values aren't supported on FreeBSD - functions related to these are disabled

User-Facing Changes

n/a

Tests + Formatting

n/a

After Submitting

n/a

nushell is verified to work on FreeBSD 14 with these patches.

What isn't supported on FreeBSD:
* the crate 'procfs' doesn't support FreeBSD yet, all functionality
  depending on procfs is disabled
* several RLIMIT_* values aren't supported on FreeBSD - functions
  related to these are disabled
@sholderbach
Copy link
Member

Thanks for doing all the work to validate that!

Should be good to go with a cargo fmt --all (cargo workspace requires the additional flag)

@sholderbach sholderbach merged commit 0487e9f into nushell:main Feb 17, 2024
19 checks passed
@hustcer hustcer added this to the v0.91.0 milestone Feb 18, 2024
@kubouch kubouch added the pr:release-note-mention Addition/Improvement to be mentioned in the release notes label Feb 18, 2024
dmatos2012 pushed a commit to dmatos2012/nushell that referenced this pull request Feb 20, 2024
# Description

nushell is verified to work on FreeBSD 14 with these patches.

What isn't supported on FreeBSD:
* the crate 'procfs' doesn't support FreeBSD yet, all functionality
depending on procfs is disabled
* several RLIMIT_* values aren't supported on FreeBSD - functions
related to these are disabled




# User-Facing Changes
n/a

# Tests + Formatting
n/a

# After Submitting
n/a

---------

Co-authored-by: sholderbach <sholderbach@users.noreply.github.com>
kik4444 pushed a commit to kik4444/nushell-fork that referenced this pull request Feb 28, 2024
# Description

nushell is verified to work on FreeBSD 14 with these patches.

What isn't supported on FreeBSD:
* the crate 'procfs' doesn't support FreeBSD yet, all functionality
depending on procfs is disabled
* several RLIMIT_* values aren't supported on FreeBSD - functions
related to these are disabled




# User-Facing Changes
n/a

# Tests + Formatting
n/a

# After Submitting
n/a

---------

Co-authored-by: sholderbach <sholderbach@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:release-note-mention Addition/Improvement to be mentioned in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants