nu-table: Improve table -a

[zhiburt]

Hi there;

Sorry took that long to respond.

I guess it's good?
It will consume the whole stream whether possible.
I do believe it will be faster in WSL in general too (in a sense of whole buffer output), but its interesting issue probably needed to be separated. It was not very well explained as well.

> 0..2000 | table -a 2
╭───┬──────╮
│ 0 │    0 │
│ 1 │    1 │
│ 2 │ ...  │
│ 3 │ 1999 │
│ 4 │ 2000 │
╰───┴──────╯

Take care

fix: #11845

cc: @fdncred

[fdncred]

@zhiburt for some reason this is breaking ci with things like these. Any ideas what's going on?

test commands::table::table_abbreviation has been running for over 60 seconds
test commands::table::table_abbreviation_by_config has been running for over 60 seconds

[fdncred]

@zhiburt something about these tests isn't quite right. any ideas?

[fdncred]

definitely closer.

[zhiburt]

Don't forget to squash commits.

Yes I was not sure about -a 0 and made it return empty result.

[fdncred]

thanks again @zhiburt!

[fdncred]

@zhiburt one more question. i just want to make sure this stream collect is only being called with -a, we don't want to be collecting on other table modes. can you confirm that is correct?

[zhiburt]

i just want to make sure this stream collect is only being called with -a, we don't want to be collecting on other table modes. can you confirm that is correct?

Correct

nushell/crates/nu-command/src/viewers/table.rs

Lines 800 to 810 in 73266ea

	match self.cfg.abbreviation {
	Some(abbr) => {
	(batch, _, end) =
	stream_collect_abbriviated(&mut self.stream, abbr, self.ctrlc.clone());
	}
	None => {
	// Pull from stream until time runs out or we have enough items
	(batch, end) =
	stream_collect(&mut self.stream, STREAM_PAGE_SIZE, self.ctrlc.clone());
	}
	}

[fdncred]

Thanks!