add is-not-empty command as a QOL improvement
#11991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rename to |
|
@fdncred I've pranked you and changed my mind 😛. I think Also, I looked over the code and it looks good! |
|
ok, thanks @IanManske. appreciate your eyes on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
is-not-emptyas a counterpart tois-empty. It's the same code but negates the results. This command has been asked for many times. So, I thought it would be nice for our community to add it just as a quality-of-life improvement. This allows people to stop writing theirdef is-not-empty [] { not ($in | is-empty) }custom commands.I'm sure there will be some who disagree with adding this, I just think it's like we have
inandnot-inand helps fill out the language and makes it a little easier to use.User-Facing Changes
Tests + Formatting
After Submitting