Fix touch
to allow changing timestamps on directories, remake from #11760
#12005
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based off of #11760 to be mergable without conflicts.
Description
Fix for #11757.
The main issue in #11757 is I tried to copy the timestamp from one directory to another only to realize that did not work whereas the coreutils
^touch
had no problems. I thought--reference
just did not work, but apparently the wholetouch
command could not work on directories becauseOpenOptions::new().write(true).create(true).open(&item)
tries to createtouch
's target in advance and then modify its timestamps. But if the target is a directory that already exists then this would fail even though the crate used for working with timestamps,filetime
, already works on directories.User-Facing Changes
I don't believe this should change any existing valid behaviors. It just changes a non-working behavior.
Tests + Formatting
I only could not runcargo test
because I get compilation errors on the latest main branchAll tests pass with
cargo test --features=sqlite
After Submitting