Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable flaky network tests #12010

Merged
merged 2 commits into from Feb 28, 2024
Merged

Conversation

IanManske
Copy link
Member

Description

Ignores some network tests that sometimes fail in CI. E.g., in 11953 and 11654.

@sholderbach
Copy link
Member

Probably for the better with all the failures on those domains recently. Should we slap a reason on the #[ignore] to make it easier to filter for them?

@fdncred
Copy link
Collaborator

fdncred commented Feb 28, 2024

It is indeed friggin annoying. I've restarted dozens of CIs due to those errors.

@IanManske IanManske merged commit 0126620 into nushell:main Feb 28, 2024
19 checks passed
@hustcer hustcer added this to the v0.91.0 milestone Feb 29, 2024
@IanManske IanManske deleted the flaky-network-tests branch March 26, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants