Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: process empty headers in to md command #12012

Merged
merged 3 commits into from Feb 29, 2024
Merged

fix: process empty headers in to md command #12012

merged 3 commits into from Feb 29, 2024

Conversation

PanGan21
Copy link
Contributor

@PanGan21 PanGan21 commented Feb 28, 2024 •
edited

fixes #12006

Description

Process empty headers as well in to md command.

User-Facing Changes

Tests + Formatting

After Submitting

@PanGan21 PanGan21 mentioned this pull request Feb 28, 2024
Closed
@fdncred
Copy link
Collaborator

fdncred commented Feb 28, 2024

Thanks for the PR. Looks like some tests might be failing.

@PanGan21 PanGan21 marked this pull request as draft February 28, 2024 21:05
@PanGan21 PanGan21 marked this pull request as ready for review February 28, 2024 22:45
@PanGan21
Copy link
Contributor Author

PanGan21 commented Feb 28, 2024 •
edited

Thanks for the PR. Looks like some tests might be failing.

Thanks! I made another change that doesn't impact other parts.
Could we run the pipeline if possible?

@PanGan21 PanGan21 changed the title fix(12006): merge descriptors ignoring empty values fix: process empty headers in to md command Feb 28, 2024
@fdncred fdncred added pr:bugfix This PR fixes some bug pr:commands This PR changes our commands in some way labels Feb 29, 2024
@fdncred fdncred merged commit f24877b into nushell:main Feb 29, 2024
19 checks passed
@fdncred
Copy link
Collaborator

fdncred commented Feb 29, 2024

thanks

@hustcer hustcer added this to the v0.91.0 milestone Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr:bugfix This PR fixes some bug pr:commands This PR changes our commands in some way
Projects
None yet
Milestone
v0.91.0
Development

Successfully merging this pull request may close these issues.

to md ignores columns with empty header
3 participants
@PanGan21 @fdncred @hustcer