Replace panics with errors in thread spawning #12040
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace panics with errors in thread spawning.
Also adds
IntoSpanned
trait for easily constructingSpanned
, and an implementation ofFrom<Spanned<std::io::Error>>
forShellError
, which is used to provide context for the error wherever there was a span conveniently available. In general this should make it more convenient to do the right thing withstd::io::Error
and always add a span to it when it's possible to do so.User-Facing Changes
Fewer panics!
Tests + Formatting
toolkit fmt
toolkit clippy
toolkit test
toolkit test stdlib