Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in comments #12052

Merged
merged 1 commit into from Mar 3, 2024
Merged

Fix typos in comments #12052

merged 1 commit into from Mar 3, 2024

Conversation

geekvest
Copy link
Contributor

@geekvest geekvest commented Mar 3, 2024

Description

Fix typos in comments

User-Facing Changes

Tests + Formatting

After Submitting

Signed-off-by: geekvest <cuimoman@sohu.com>
@ysthakur
Copy link
Member

ysthakur commented Mar 3, 2024

Thanks for the PR. Nothing wrong the changes themselves, but I think the title of this PR is a bit misleading (I initially thought there was code duplication). I'd suggest something along the lines of "Fix typos in comments." Also, I know these changes are pretty small, but it would help to add a description so that people know what this PR does without having to look at the changes.

@geekvest geekvest changed the title remove repetitive code Fix typos in comments Mar 3, 2024
@geekvest
Copy link
Contributor Author

geekvest commented Mar 3, 2024

Thanks for the PR. Nothing wrong the changes themselves, but I think the title of this PR is a bit misleading (I initially thought there was code duplication). I'd suggest something along the lines of "Fix typos in comments." Also, I know these changes are pretty small, but it would help to add a description so that people know what this PR does without having to look at the changes.

Thanks! Please review again.

@fdncred fdncred merged commit 3ee2fc6 into nushell:main Mar 3, 2024
19 checks passed
@fdncred
Copy link
Collaborator

fdncred commented Mar 3, 2024

Thanks

@hustcer hustcer added this to the v0.91.0 milestone Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants