Adjust examples in date commands #12055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove two incorrect examples for `date to-record` and `date to-table` where nothing was piped in (which causes an error in actual use). - Fix misleading descriptions in `date to-timezone` which erroneously referred to Hawaii's time zone. - Standardise on "time zone" in written descriptions. - Generally tidy up example descriptions and improve consistency.
robjwells
force-pushed
the
descriptions-5066
branch
from
68305bd
to
0340b01
Compare
|
The force-push was just me rebasing the branch on upstream/main. No other changes. |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! This is my first PR to nushell, as I was looking at things for #5066. The usage text for the date commands seemed fine to me, so this is just a bit of a tidy up of the examples, mostly the description text.
Description
Remove two incorrect examples for
date to-recordanddate to-tablewhere nothing was piped in (which causes an error in actual use).Fix misleading descriptions in
date to-timezonewhich erroneously referred to Hawaii's time zone.Standardise on "time zone" in written descriptions.
Generally tidy up example descriptions and improve consistency.
User-Facing Changes
Only in related help text showing examples.