Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unexpected sqlite insert behaviour (attempt 2) #12128

Conversation

NowackiPatryk
Copy link
Contributor

@NowackiPatryk
Copy link
Contributor Author

@rgwood Moved unnecessary stuff out of loop so it should be a bit faster now.

@rgwood rgwood changed the title fix: unexpected sqlite insert behaviour Fix into sqlite performance regression Mar 8, 2024
@rgwood rgwood changed the title Fix into sqlite performance regression Fix unexpected sqlite insert behaviour (attempt 2) Mar 8, 2024
@rgwood
Copy link
Contributor

rgwood commented Mar 8, 2024

Thanks! into sqlite seems about 1.5x slower than before the fix, which is acceptable and much better than the previous PR (1000x).

Don't think it needs to happen in this PR, but it would be nice to have tests to verify that the column order does not matter.

@rgwood rgwood merged commit a9ddc58 into nushell:main Mar 8, 2024
19 checks passed
@hustcer hustcer added this to the v0.92.0 milestone Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants