Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests Playground #12134

Merged
merged 5 commits into from Mar 9, 2024
Merged

Conversation

ysthakur
Copy link
Member

@ysthakur ysthakur commented Mar 9, 2024

Description

It looks like Playground and Director in nu-tests-support haven't gotten much love recently, so this PR is for updating them to work with newer Nushell versions.

  • Director adds a --skip-plugins argument before running nu, but that doesn't exist anymore, so I removed it.
  • Director also adds a --perf argument, which also doesn't exist anymore. I added --log-level info instead to get the performance output.
  • It doesn't seem like anyone was using playground::matchers, and it used the hamcrest2 crate, which appears to be unmaintained, so I got rid of that (and the hamcrest2 dependency).
  • Inside tests/fixtures/playground/config were two files in the old config format: default.toml and startup.toml. I removed those too.

User-Facing Changes

None, these changes only mess with tests.

Tests + Formatting

After Submitting

@rgwood
Copy link
Contributor

rgwood commented Mar 9, 2024

Thank you!! Our test infrastructure has been a bit… “there be dragons” for a long time, really nice to see someone cleaning it up.

@rgwood rgwood merged commit c906404 into nushell:main Mar 9, 2024
20 checks passed
@ysthakur ysthakur deleted the nushell-update-playground branch March 9, 2024 04:45
@hustcer hustcer added this to the v0.92.0 milestone Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants