Fix ignored clippy lints #12160
Merged
Fix ignored clippy lints #12160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sholderbach
reviewed
Mar 11, 2024
| } else if i == chars.len() { | ||
| true | ||
| // `**` ends in non-separator | ||
| match count.cmp(&2) { |
There was a problem hiding this comment.
Not quite sure if this monster gets much more readable. maybe worth pullilng the Less branch up?
| @@ -788,11 +787,11 @@ impl EngineState { | |||
| self.vars[var_id].const_val = Some(val); | |||
| } | |||
|
|
|||
| #[allow(clippy::borrowed_box)] | |||
| pub fn get_decl(&self, decl_id: DeclId) -> &Box<dyn Command> { | |||
| pub fn get_decl(&self, decl_id: DeclId) -> &dyn Command { | |||
There was a problem hiding this comment.
Oh yes (walked past that today SMH)
| @@ -48,7 +48,6 @@ pub fn build_table(value: Value, description: String, termsize: usize) -> String | |||
|
|
|||
| add_padding_to_widths(&mut widths); | |||
|
|
|||
| #[allow(clippy::manual_clamp)] | |||
There was a problem hiding this comment.
Ah they made that generally allow again. I think this is only an undefined resolution for float. So the code below could be a safe clamp, right?
There was a problem hiding this comment.
Ah the .max/.min solution never panics.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes some ignored clippy lints.
User-Facing Changes
Changes some signatures and return types to
&dyn Commandinstead of&Box<dyn Command, but I believe this is only an internal change.