New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor benches for more command benchmarks #12171

Merged

sholderbach merged 2 commits into nushell:main from sholderbach:benchmark-tweaks

Mar 12, 2024

Member

sholderbach commented Mar 12, 2024

Refactor command benchmark
- should simplify addition of more command benchmarks
- just provide the pipeline you want to run/ choose potential scaling
Bench engine state with ctrlc set
- None vs AtomicBool behind Arc

sholderbach added 2 commits

March 12, 2024 12:52


          Refactor command benchmark

1924f21

Setup is shared for all those small pipelines. Make it more
straightforward to add new ones.


          Bench engine state with ctrlc set

fe75859

Instead of leaving `None` provide a dummy `AtomicBool` behind an `Arc`

sholderbach merged commit 13cbfd3 into nushell:main

15 checks passed

sholderbach deleted the benchmark-tweaks branch

March 12, 2024 12:10

hustcer added this to the v0.92.0 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment