Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respond to nightly clippy #12174

Merged
merged 2 commits into from Mar 20, 2024
Merged

Conversation

sholderbach
Copy link
Member

Babe, wake up new nightly clippy just dropped

  • Move catch_unwind block out of match scrutinee
  • Remove unused members in PluginExecutionContext

`cargo +nightly clippy` complains about complexity/length of the
scrutinee
They are only crate visible and unused there.
Maybe @devyn has something in mind for the future of those
@sholderbach sholderbach marked this pull request as ready for review March 18, 2024 18:32
Copy link
Collaborator

@WindSoilder WindSoilder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@WindSoilder WindSoilder merged commit f56070c into nushell:main Mar 20, 2024
15 checks passed
@hustcer hustcer added this to the v0.92.0 milestone Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants