Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 remove 3 backticks messing the hover #12273

Merged
merged 3 commits into from Mar 24, 2024
Merged

Conversation

AucaCoyan
Copy link
Contributor

@AucaCoyan AucaCoyan commented Mar 24, 2024

Description

The hover was bugged with 3 backticks. I don't understand how it worked before, but this apparently now works correctly on my machine. This is really puzzling. My next step is to make a test to assert this will break a little less. I fixed it 3 times in the past

Tests + Formatting

Added a test to be sure this doesn't breaks again 😄 (at least from nushell/nushell side)

@fdncred
Copy link
Collaborator

fdncred commented Mar 24, 2024

This fixes it for me.
Screenshot 2024-03-24 at 8 52 44 AM

@fdncred
Copy link
Collaborator

fdncred commented Mar 24, 2024

looks like mac is hung again. canceling and restarting it.

@AucaCoyan
Copy link
Contributor Author

Thanks! I was about to ask if it works in another machine just in case.
I think it is valuable to add testing from the vscode-nushell-lang repo, I'll try some testing there (we can do test CI too!)

@AucaCoyan AucaCoyan marked this pull request as ready for review March 24, 2024 14:09
@fdncred
Copy link
Collaborator

fdncred commented Mar 24, 2024

Thanks!

@fdncred fdncred merged commit b3721a2 into nushell:main Mar 24, 2024
15 checks passed
@AucaCoyan AucaCoyan deleted the fix-hover branch March 24, 2024 21:05
@hustcer hustcer added this to the v0.92.0 milestone Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants