Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead impl PluginEncoder for EncodingType #12284

Merged
merged 1 commit into from Mar 26, 2024

Conversation

sholderbach
Copy link
Member

@sholderbach sholderbach commented Mar 25, 2024

Detected due to clippy::wrong_self_convention for to_str

Breaking change to plugin authors

seems to be implementation detail

cc @devyn

Detected due to `clippy::wrong_self_convention` for `to_str`
@sholderbach sholderbach marked this pull request as ready for review March 25, 2024 21:06
@sholderbach sholderbach added the pr:api-change This PR should be mentioned in #api-updates channel on Discord label Mar 26, 2024
@sholderbach sholderbach merged commit e8bcfba into nushell:main Mar 26, 2024
15 checks passed
@sholderbach sholderbach deleted the remove-dead-impl branch March 26, 2024 11:11
@hustcer hustcer added this to the v0.92.0 milestone Mar 26, 2024
@devyn
Copy link
Contributor

devyn commented Mar 26, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:api-change This PR should be mentioned in #api-updates channel on Discord
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants