Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancel old CI runs on commit #12298

Merged
merged 6 commits into from
Mar 26, 2024
Merged

Cancel old CI runs on commit #12298

merged 6 commits into from
Mar 26, 2024

Conversation

IanManske
Copy link
Member

Description

Adds a concurrency section to the CI workflow to cancel old CI jobs when a new commit is pushed to the same branch/PR.

@fdncred
Copy link
Collaborator

fdncred commented Mar 26, 2024

I wondered why that didn't work. Definitely a good add!

@IanManske
Copy link
Member Author

Pushed another commit to demonstrate the cancellation in action. (It works!) Although, I also got an email from github saying the CI was cancelled/failed 😨

@sholderbach
Copy link
Member

Awesome addition! (especially when the dependabot runs amok around release 😆 )

Could this be made granular to only affect prs so we still get the indication on the main branch which commit broke the build?

@IanManske
Copy link
Member Author

IanManske commented Mar 26, 2024

Could this be made granular to only affect prs so we still get the indication on the main branch which commit broke the build?

It looks like it! I copied an example from the Github docs.

Edit: changed it to a ternary expression instead

@IanManske IanManske merged commit f8c1e3a into nushell:main Mar 26, 2024
15 checks passed
@hustcer hustcer added this to the v0.92.0 milestone Mar 27, 2024
@IanManske IanManske deleted the ci-concurrent branch April 24, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants