Remove ambiguous into bits impl for date
#12313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently `into bits` will try to coerce a `date`/`Value::Date` into a string with a locale/timezone specific behavior (See nushell#12268). To resolve the ambiguity, remove the support for `date` entirely. Instead you can use `... | format date '%c' | into bits` or any more specific explicit choices to achieve the same behavior. As `into bits` has minimal uses (and only pulled out of `extra` with nushell#12140), this doesn't warrant a deprecation.
sholderbach
added
pr:breaking-change
fdncred
reviewed
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently
into bitswill try to coerce adate/Value::Dateinto a string with a locale/timezone specific behavior (See #12268).To resolve the ambiguity, remove the support for
dateentirely.User-Facing Changes
date now | into bitswill now fail.Instead you can use
... | format date '%c' | into bitsor any more specific explicit choices to achieve the same behavior.As
into bitshas minimal uses (and only pulled out ofextrawith #12140), this doesn't warrant a deprecation.