Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use nightly clippy to kill dead code/fix style #12334

Merged
merged 8 commits into from Mar 30, 2024
Merged

Use nightly clippy to kill dead code/fix style #12334

merged 8 commits into from Mar 30, 2024

Conversation

sholderbach
Copy link
Member

  • Remove duplicated imports
  • Remove unused field in CompletionOptions
  • Remove unused struct in nu-table
  • Clarify generic bounds
  • Simplify a subtrait bound for ExactSizeIterator
  • Use unwrap_or_default
  • Use Option directly instead of empty string
  • Elide unneeded clone in to html

WindSoilder
WindSoilder approved these changes Mar 30, 2024
View reviewed changes
Copy link
Collaborator

@WindSoilder WindSoilder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@WindSoilder WindSoilder merged commit e889679 into nushell:main Mar 30, 2024
15 checks passed
@hustcer hustcer added this to the v0.92.0 milestone Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WindSoilder WindSoilder WindSoilder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.92.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sholderbach @WindSoilder @hustcer