Reuse existing small allocations if possible #12335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Associated clippy lint https://rust-lang.github.io/rust-clippy/master/index.html#/clone_from - This can save some allocations or drops by explicitly optimizing here. - `Clone::clone_from` should provide pretty readable semantics - `ToOwned::clone_into` maybe requires a bit more familiarity
- `String::clear(&mut self)` instead of assigning `String::new()` - `Clone::clone_from` instead of assigning new allocations - https://rust-lang.github.io/rust-clippy/master/index.html#/clone_from Still some places that may be better expressed by e.g. `std::mem::take` when passing around `String`s, but that could also be revisited with good use of references
|
TIL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those allocations are all small and insignificant in the grand scheme of things and the optimizer may be able to resolve some of those but better to be nice anyways.
Primarily inspired by the new
clippy::assigning_clonesclone_frominnu-parserStackclippy::assigning_clonesinnu-clinu-exploreif possible