Make default config conservative about clipboard #12385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some platforms don't support the `system-clipboard` feature, notably termux on android. The default config currently contained references to `reedline` events that are only available with the feature enabled (nushell#12179). This thus broke the out of the box config for those users. For now be more defensive about this and only enable default events. Add the alternative as commented out code you can quickly enable.
|
So fast! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some platforms don't support the
system-clipboardfeature, notably termux on android.The default config currently contained references to
reedlineevents that are only available with the feature enabled (#12179). This thus broke the out of the box config for those users.For now be more defensive about this and only enable default events. Add the alternative as commented out code you can quickly enable.
Tested with: