Fix #12391: mkdir uses process startup directory instead of current script directory #12394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rrent script directory nushell/nushell@87c5f6e455 accidentally introduced a bug where the path was not being properly expanded according to the cwd. This makes both 'touch' and 'mkdir' use globs just like the rest of the commands to preserve tilde behavior while still expanding the paths properly.
@WindSoilder can you take a look at this since it's changing some things in your PR? |
sholderbach
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes #12391.
87c5f6e455 accidentally introduced a bug where the path was not being properly
expanded according to the cwd. This makes both 'touch' and 'mkdir' use globs just like the rest of
the commands to preserve tilde behavior while still expanding the paths properly.
This doesn't actually expand the globs. Should it?
User-Facing Changes
mkdir,touchTests + Formatting
Regression tests added.
toolkit fmttoolkit clippytoolkit testtoolkit test stdlibAfter Submitting
This is severe enough and should be included in the point release.