-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set Up Config in LSP Mode #12454
Set Up Config in LSP Mode #12454
Conversation
@fdncred, I was wondering if you wait a little with merging because I reviewed the changes here and I was wondering if we should implement What do you think? |
I'd be good with landing this one and then doing the workspace/configuration in a separate one. I haven't tried this one out but looking at the code, it seems like it may do what I'm talking about. Then we can tweak on that in a separate PR. How's that sound? |
Sounds great. |
I still get the same diagnostic errors after this change but I'm not sure why. Trying to think of another way to test this. 🤔 |
If I do I get the same errors if I just do I confirmed that before this PR, those errors do not show up. So something is not quite right here. |
8276bef
to
eb606ce
Compare
@fdncred, I tried your commands on my Linux machine and they work just fine. If I remember correctly, you are on Windows, right? Could you try the version after rebase? Maybe, I refactor the code so that it runs after initializing the LSP. |
@schrieveslaach I get this on MacOS. I can try Windows on Monday. It looks like it's trying to work but it's not finding everything right or merging it? 🤔 |
When starting the LSP server, the configuration file and environment file are used to configure the LSP engine unless --no-config-file is provided.
eb606ce
to
4afc14b
Compare
Ah, I think the LSP start was in the wrong spot. And I have no usage of |
Let me know if there's anything else you want to add, otherwise I'll land this. |
I will create another PR that will add |
ok, thanks. |
Description
When starting the LSP server, the configuration file and environment file are used to configure the LSP engine unless --no-config-file is provided.
This PR provides an improvement that is related to #10794
CC: @fdncred