Add deprecation warning to describe --collect-lazyrecords
#12667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanManske
commented
Apr 25, 2024
Comment on lines
+50
to
+51
| nu_protocol::report_error_new( | ||
| engine_state, |
There was a problem hiding this comment.
I didn't add the warning for run_const, since report_error_new needs an engine state. lazy make is not const, so this hopefully won't be a problem.
maxim-uvarov
pushed a commit
to maxim-uvarov/nushell
that referenced
this pull request
May 1, 2024
…12667) # Description Missed a spot for lazy record deprecation. This adds a warning for the `--collect-lazyrecords` flag on `describe`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Missed a spot for lazy record deprecation. This adds a warning for the
--collect-lazyrecordsflag ondescribe.