Make get_full_help take &dyn Command
#12903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sholderbach
reviewed
May 19, 2024
|
It looks like custom sub commands like I believe the only quick with custom commands is that they can't be run directly with |
sholderbach
reviewed
May 19, 2024
| let b_distance = levenshtein_distance(line, &b.name); | ||
| a_distance.cmp(&b_distance) | ||
| }); | ||
| commands.sort_by_cached_key(|decl| levenshtein_distance(line, decl.name())); |
| &self, | ||
| include_hidden: bool, | ||
| ) -> impl Iterator<Item = (Vec<u8>, DeclId)> { | ||
| pub fn get_decls_sorted(&self, include_hidden: bool) -> Vec<(Vec<u8>, DeclId)> { |
There was a problem hiding this comment.
Makes sense with the current implementation, if we have to allocate for the deduping and sorting anyways.
(the question if HashMap then Vec sort beats out the BTreeMap is one of those "what is the real data you run it with anyways" perf questions)
sholderbach
approved these changes
May 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes
get_full_helpto take a&dyn Commandinstead of multiple arguments (&Signature,&Examplesis_parser_keyword). All of these arguments can be gathered from aCommand, so there is no need to pass the pieces toget_full_help.This PR also fixes an issue where the search terms are not shown if
--helpis used on a command.