Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix use of export/alias --help bug #5332

Merged
merged 2 commits into from Apr 26, 2022
Merged

Fix use of export/alias --help bug #5332

merged 2 commits into from Apr 26, 2022

Conversation

gipsyh
Copy link
Contributor

@gipsyh gipsyh commented Apr 26, 2022

Description

Fix #4653

Tests

Make sure you've run and fixed any issues with these commands:

  • cargo fmt --all -- --check to check standard code formatting (cargo fmt --all applies these changes)
  • cargo clippy --all --all-features -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect to check that you're using the standard code style
  • cargo build; cargo test --all --all-features to check that all the tests pass

Signed-off-by: SuYuheng <yuheng.su@motiong.com>
@gipsyh gipsyh changed the title Fix use of export/alias --help bug #4653 Fix use of export/alias --help bug Apr 26, 2022
Signed-off-by: SuYuheng <yuheng.su@motiong.com>
@fdncred
Copy link
Collaborator

fdncred commented Apr 26, 2022

oh, nice work here! thanks!

@fdncred fdncred merged commit fb8f7b1 into nushell:main Apr 26, 2022
@gipsyh gipsyh deleted the fix_alias_and_export_help_bug branch April 27, 2022 01:57
fennewald pushed a commit to fennewald/nushell that referenced this pull request Jun 27, 2022
* fix alias --help bug

Signed-off-by: SuYuheng <yuheng.su@motiong.com>

* fix export --help bug

Signed-off-by: SuYuheng <yuheng.su@motiong.com>

Co-authored-by: SuYuheng <yuheng.su@motiong.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

export --help not work
2 participants