Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #5578, assume pipe file be zero-sized #5594

Merged
merged 2 commits into from May 20, 2022
Merged

Conversation

hustcer
Copy link
Contributor

@hustcer hustcer commented May 20, 2022

Description

Fix #5578, assume pipe file be zero-sized

Tests

Make sure you've run and fixed any issues with these commands:

  • cargo fmt --all -- --check to check standard code formatting (cargo fmt --all applies these changes)
  • cargo clippy --workspace --features=extra -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect to check that you're using the standard code style
  • cargo test --workspace --features=extra to check that all the tests pass

@fdncred
Copy link
Collaborator

fdncred commented May 20, 2022

good idea. thanks

@fdncred fdncred merged commit 0ba86d7 into nushell:main May 20, 2022
@hustcer hustcer deleted the fix/pipe-ls branch May 20, 2022 14:41
fennewald pushed a commit to fennewald/nushell that referenced this pull request Jun 27, 2022
* Fix nushell#5578, assume pipe file be zero-sized

* rust fmt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type mismatch with "where size > 4kb"
2 participants