Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clippy and remove unused is_binary #5879

Merged
merged 1 commit into from Jun 25, 2022
Merged

Conversation

sophiajt
Copy link
Member

Description

Looks like the is_binary of Command doesn't seem to be used. Whether something is binary or not should probably instead be part of the output type of the Signature. We also encode binary as just part of the stream as well.

Also fixed the clippy warnings I saw

Tests

Make sure you've done the following:

  • Add tests that cover your changes, either in the command examples, the crate/tests folder, or in the /tests folder.
  • Try to think about corner cases and various ways how your changes could break. Cover them with tests.
  • If adding tests is not possible, please document in the PR body a minimal example with steps on how to reproduce so one can verify your change works.

Make sure you've run and fixed any issues with these commands:

  • cargo fmt --all -- --check to check standard code formatting (cargo fmt --all applies these changes)
  • cargo clippy --workspace --features=extra -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect to check that you're using the standard code style
  • cargo test --workspace --features=extra to check that all the tests pass

@sophiajt sophiajt merged commit 575ddbd into nushell:main Jun 25, 2022
@sophiajt sophiajt deleted the minor_fixes branch June 25, 2022 20:20
fennewald pushed a commit to fennewald/nushell that referenced this pull request Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant