New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sort logic available outside sort-by #5893
Conversation
@rgwood for now until you can figure out a better place for it I would put |
@stormasm 1 problem with that: the |
oh ! this actually hearkens back to our conversation the other day on discord when we were discussing this idea of the melding of nana and nushell... so we we need a place where the "rust nana code lives" so I guess the spot you have it is fine (for now).... |
@rgwood so I read the discord channel after my previous message here and saw that @jntrnr said option 2 of nu-utils but then @fdncred had a great point about why that is not a good spot... so since you are working a lot on the Nana code I would probably plan on eventually when you see fit or a "good time" to start up that new crate with some appropriate name for all future nana / nushell melding code.... |
@rgwood here is one name for a crate that is kind of obvious, not sure if you like it... nu-nana Not sure what other folks think... |
@stormasm not sure about nu-nana; this sorting code is needed by the |
@rgwood so we are looking for a crate name for code or our melding code of both projects... it will be fun to come up with a name that works... |
I'd also add that |
I'll merge this today if there are no objections. |
lgtm |
Description
This PR moves sorting logic so it is accessible by consumers of the
nu-command
crate. It also creates 2 helper functions. This work is being done to enable interactive sorting of card results in Nana.Tests
Make sure you've done the following:
Make sure you've run and fixed any issues with these commands:
cargo fmt --all -- --check
to check standard code formatting (cargo fmt --all
applies these changes)cargo clippy --workspace --features=extra -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect
to check that you're using the standard code stylecargo test --workspace --features=extra
to check that all the tests pass