Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

concat string with lazy expressions #6093

Merged
merged 1 commit into from Jul 21, 2022

Conversation

elferherrera
Copy link
Contributor

@elferherrera elferherrera commented Jul 21, 2022

Description

This allows to create a new column using lazy expressions

let df = ([[a b c]; [one two 1] [three four 2]] | into df);

$df | with-column ((concat-str "-" [(col a) (col b) ((col c) * 2)]) | as concat)

Tests

Make sure you've done the following:

  • Add tests that cover your changes, either in the command examples, the crate/tests folder, or in the /tests folder.
  • Try to think about corner cases and various ways how your changes could break. Cover them with tests.
  • If adding tests is not possible, please document in the PR body a minimal example with steps on how to reproduce so one can verify your change works.

Make sure you've run and fixed any issues with these commands:

  • cargo fmt --all -- --check to check standard code formatting (cargo fmt --all applies these changes)
  • cargo clippy --workspace --features=extra -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect to check that you're using the standard code style
  • cargo test --workspace --features=extra to check that all the tests pass

@elferherrera elferherrera merged commit b2ec32f into nushell:main Jul 21, 2022
merelymyself pushed a commit to merelymyself/nushell that referenced this pull request Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant