Fix file lookup in parser keywords; Refactor nu_repl #6185
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the logic used to look up files in parser keywords which was broke NU_LIB_DIRS.
In order to test it, I had to use the
nu_repl()
simulator. However, I discovered thatnu_repl()
changes directory for the whole test binary which would cause a lot of other tests fail. To address that, I movednu_repl()
to be a testbin which means it will run in its own Nushell instance. This means, it's possible to runnu --testbin=nu_repl line1 line2
and it would be executed as if you typedin the Nushell REPL.
Fixes #6184
Tests
Make sure you've done the following:
Make sure you've run and fixed any issues with these commands:
cargo fmt --all -- --check
to check standard code formatting (cargo fmt --all
applies these changes)cargo clippy --workspace --features=extra -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect
to check that you're using the standard code stylecargo test --workspace --features=extra
to check that all the tests pass