Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use from table to remove into-db command #6205

Merged
merged 2 commits into from Aug 1, 2022

Conversation

elferherrera
Copy link
Contributor

@elferherrera elferherrera commented Aug 1, 2022

Description

Change db command from to from table to eliminate the need to use into db when using db commands.
into db is used as type hint for the parser to understand that the next commands that will be used are the db commands and not the regular nu commands

Examples
Before

open db.sqlite
| into db
| from table_1
| select a
| as t1

Suggested change

open db.sqlite
| from table table_1
| select a
| as t1

Note. Also the name of the test file was changed from db.mysql to db.sqlite to better represent what type of files are being opened

Tests

Make sure you've done the following:

  • Add tests that cover your changes, either in the command examples, the crate/tests folder, or in the /tests folder.
  • Try to think about corner cases and various ways how your changes could break. Cover them with tests.
  • If adding tests is not possible, please document in the PR body a minimal example with steps on how to reproduce so one can verify your change works.

Make sure you've run and fixed any issues with these commands:

  • cargo fmt --all -- --check to check standard code formatting (cargo fmt --all applies these changes)
  • cargo clippy --workspace --features=extra -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect to check that you're using the standard code style
  • cargo test --workspace --features=extra to check that all the tests pass

@rgwood
Copy link
Contributor

rgwood commented Aug 1, 2022

Thanks for fixing the examples!

@elferherrera elferherrera merged commit 1f4791a into nushell:main Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants