Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow parsing modules as scripts #6357

Merged
merged 6 commits into from Aug 22, 2022
Merged

Conversation

kubouch
Copy link
Contributor

@kubouch kubouch commented Aug 18, 2022

Description

Any export encountered in a script will be ignored. So, for example, export def will be treated just like a regular def.

export env is not supported because it will be deleted anyway in favor of export-env.

Tests

Make sure you've done the following:

  • Add tests that cover your changes, either in the command examples, the crate/tests folder, or in the /tests folder.
  • Try to think about corner cases and various ways how your changes could break. Cover them with tests.
  • If adding tests is not possible, please document in the PR body a minimal example with steps on how to reproduce so one can verify your change works.

Make sure you've run and fixed any issues with these commands:

  • cargo fmt --all -- --check to check standard code formatting (cargo fmt --all applies these changes)
  • cargo clippy --workspace --features=extra -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect to check that you're using the standard code style
  • cargo test --workspace --features=extra to check that all the tests pass

@kubouch kubouch marked this pull request as ready for review August 22, 2022 20:23
@kubouch kubouch merged commit 7ef4e5f into nushell:main Aug 22, 2022
dheater pushed a commit to dheater/nushell that referenced this pull request Sep 2, 2022
* Allow parsing modules as scripts

* Remove 'export env' from the supported keywords

* Add test for export in blocks; Allow "export use"

* Allow evaluating "export alias"

* Fmt; Clippy

* Allow running "export extern" in scripts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant