Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add history session id to $nu #6585

Merged
merged 3 commits into from Sep 19, 2022
Merged

add history session id to $nu #6585

merged 3 commits into from Sep 19, 2022

Conversation

fdncred
Copy link
Collaborator

@fdncred fdncred commented Sep 19, 2022

Description

This PR adds the reedline history session id to the $nu variable. When using the sqlite history db, this should make it easier to query history records by history session. A new history session is created with every new instance of reedline, so every new instance of nushell.

Screen Shot 2022-09-18 at 9 18 39 PM

The history session id is stored at time since UNIX_EPOCH in nanoseconds but is not intended to be used as any type of a timing mechanism. It's just meant to try and have a mostly unique history session id, that fits within the datatype. If we have to move to a ulid, we'll have to change the data type, which we don't really want to do.

This PR is dependent on nushell/reedline#485 so, I'll make this a draft until the reedline PR is landed.

Note: I couldn't get ci to see the right main branch in reedline without specifically pointing it out. Not sure if it was cached or what.

Tests

Make sure you've done the following:

  • Add tests that cover your changes, either in the command examples, the crate/tests folder, or in the /tests folder.
  • Try to think about corner cases and various ways how your changes could break. Cover them with tests.
  • If adding tests is not possible, please document in the PR body a minimal example with steps on how to reproduce so one can verify your change works.

Make sure you've run and fixed any issues with these commands:

  • cargo fmt --all -- --check to check standard code formatting (cargo fmt --all applies these changes)
  • cargo clippy --workspace --features=extra -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect to check that you're using the standard code style
  • cargo test --workspace --features=extra to check that all the tests pass

@fdncred fdncred marked this pull request as ready for review September 19, 2022 12:34
@fdncred fdncred merged commit 0b9dd87 into nushell:main Sep 19, 2022
@fdncred fdncred deleted the hist_session_id branch September 19, 2022 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant