Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the reedline history session id to the
$nu
variable. When using the sqlite history db, this should make it easier to query history records by history session. A new history session is created with every new instance of reedline, so every new instance of nushell.The history session id is stored at time since UNIX_EPOCH in nanoseconds but is not intended to be used as any type of a timing mechanism. It's just meant to try and have a mostly unique history session id, that fits within the datatype. If we have to move to a ulid, we'll have to change the data type, which we don't really want to do.
This PR is dependent on nushell/reedline#485 so, I'll make this a draft until the reedline PR is landed.
Note: I couldn't get ci to see the right main branch in reedline without specifically pointing it out. Not sure if it was cached or what.
Tests
Make sure you've done the following:
Make sure you've run and fixed any issues with these commands:
cargo fmt --all -- --check
to check standard code formatting (cargo fmt --all
applies these changes)cargo clippy --workspace --features=extra -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect
to check that you're using the standard code stylecargo test --workspace --features=extra
to check that all the tests pass