Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove month and year duration constants #6613

Merged
merged 3 commits into from
Sep 25, 2022

Conversation

sophiajt
Copy link
Contributor

@sophiajt sophiajt commented Sep 25, 2022

Description

Some of the humanize logic got mixed into the parsing and duration models, so this removes those but keeps the humanized print. With it, we'll no longer support 1yr or 1month, or any duration above 1wk as the former do not have fixed values.

This should help people create more predictable duration constants.

Tests

Make sure you've done the following:

  • Add tests that cover your changes, either in the command examples, the crate/tests folder, or in the /tests folder.
  • Try to think about corner cases and various ways how your changes could break. Cover them with tests.
  • If adding tests is not possible, please document in the PR body a minimal example with steps on how to reproduce so one can verify your change works.

Make sure you've run and fixed any issues with these commands:

  • cargo fmt --all -- --check to check standard code formatting (cargo fmt --all applies these changes)
  • cargo clippy --workspace --features=extra -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect to check that you're using the standard code style
  • cargo test --workspace --features=extra to check that all the tests pass

@sophiajt sophiajt changed the title Remove month year Remove month and year duration constants Sep 25, 2022
@sophiajt sophiajt merged commit d66a539 into nushell:main Sep 25, 2022
@sophiajt sophiajt deleted the remove_month_year branch September 25, 2022 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant