let start open anything and everything
#7580
Conversation
|
Thanks for the PR. I don't think we should add this functionality to IIRC Nu used to have this functionality in a We might be open to bringing this functionality back but I don't think it should happen in |
|
ya, I'd support a |
|
@fdncred do you prefer a plugin to a built-in command? |
|
@rgwood my tendency is to go with a plugin because that's what we had before. someone made that decision, i don't remember who. but it wouldn't hurt my feelings to have it built-in either. |
|
I think I’d prefer a built-in command; the impact on compile time and binary size should be negligible. |
|
Sorry, pressed the wrong button on my phone and closed this a bit too early. |
|
@rgwood I would want to use the original crate though. It does quite a bit more checking and looks like it makes pretty good decisions per platform. |
| } | ||
| } | ||
|
|
||
| fn examples(&self) -> Vec<nu_protocol::Example> { |
There was a problem hiding this comment.
These examples look like they're for open vs open-dir
|
Not sure how I feel about |
|
I don’t like the name open-dir because the command should be able to open files as well as directories. |
Does that mean your proposal is to rename it to |
|
I think |
merelymyself
changed the title
open-dir open directoriesstart open anything and everything
Description
Fixes #7546 's request. I'm unsure, so hopefully someone in charge of design can chip in.
User-Facing Changes
opennow opens directories in the default file manager.Tests + Formatting
Don't forget to add tests that cover your changes.
Make sure you've run and fixed any issues with these commands:
cargo fmt --all -- --checkto check standard code formatting (cargo fmt --allapplies these changes)cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collectto check that you're using the standard code stylecargo test --workspaceto check that all tests passAfter Submitting
If your PR had any user-facing changes, update the documentation after the PR is merged, if necessary. This will help us keep the docs up to date.