Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix command name lookup for known externals #7830

Merged
merged 1 commit into from Jan 22, 2023

Conversation

kubouch
Copy link
Contributor

@kubouch kubouch commented Jan 22, 2023

Description

When known externals were imported from modules with a prefix (use spam instead of use spam *), it was impossible to call them. This PR fixes it.

Fixes #7822

The following now works:

> module cargo { export extern check [] }
> use cargo
> cargo check

User-Facing Changes

Enables subcommand folding of modules with export externs. Should not break anything.

Tests + Formatting

Don't forget to add tests that cover your changes.

Make sure you've run and fixed any issues with these commands:

  • cargo fmt --all -- --check to check standard code formatting (cargo fmt --all applies these changes)
  • cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect to check that you're using the standard code style
  • cargo test --workspace to check that all tests pass

After Submitting

If your PR had any user-facing changes, update the documentation after the PR is merged, if necessary. This will help us keep the docs up to date.

@kubouch kubouch merged commit ba12b0d into nushell:main Jan 22, 2023
@kubouch kubouch deleted the known-subcommand branch January 22, 2023 19:40
Xoffio pushed a commit to Xoffio/nushell that referenced this pull request Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Known externals do not work well with module exports
1 participant