Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update cargo wix to 0.3.4 #8048

Merged
merged 1 commit into from Feb 12, 2023
Merged

update cargo wix to 0.3.4 #8048

merged 1 commit into from Feb 12, 2023

Conversation

fdncred
Copy link
Collaborator

@fdncred fdncred commented Feb 11, 2023

Description

hopefully this will make the next winget release go smoother

User-Facing Changes

Tests + Formatting

Don't forget to add tests that cover your changes.

Make sure you've run and fixed any issues with these commands:

  • cargo fmt --all -- --check to check standard code formatting (cargo fmt --all applies these changes)
  • cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect to check that you're using the standard code style
  • cargo test --workspace to check that all tests pass

After Submitting

If your PR had any user-facing changes, update the documentation after the PR is merged, if necessary. This will help us keep the docs up to date.

hopefully this will make the next winget release go smoother
@codecov
Copy link

codecov bot commented Feb 12, 2023

Codecov Report

Base: 55.23% // Head: 55.23% // No change to project coverage 👍

Coverage data is based on head (dca6ede) compared to base (9777d75).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8048   +/-   ##
=======================================
  Coverage   55.23%   55.23%           
=======================================
  Files         606      606           
  Lines       99065    99065           
=======================================
  Hits        54720    54720           
  Misses      44345    44345           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sophiajt sophiajt added this pull request to the merge queue Feb 12, 2023
Merged via the queue into main with commit 1096e65 Feb 12, 2023
@fdncred fdncred deleted the fdncred-patch-1 branch February 12, 2023 13:23
@hustcer
Copy link
Contributor

hustcer commented Feb 13, 2023

I guess this is not an issue on our side, might be an issue from winget, for more detail see: microsoft/winget-pkgs#95543 (comment)
We can try it for the next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants