Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix insecure + max-time arguments for HTTP commands. #8266

Merged
merged 1 commit into from
Feb 28, 2023

Conversation

jaudiger
Copy link
Contributor

Description

Follow up of #8255

Sorry about the max-time argument, I didn't pay attention to the copy-paste. Regarding the insecure argument, the problem was before I began to work on the refacto. My mistake was to not have tested this argument.

User-Facing Changes

None.

Tests + Formatting

Don't forget to add tests that cover your changes.

Make sure you've run and fixed any issues with these commands:

  • cargo fmt --all -- --check to check standard code formatting (cargo fmt --all applies these changes)
  • cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect to check that you're using the standard code style
  • cargo test --workspace to check that all tests pass

After Submitting

If your PR had any user-facing changes, update the documentation after the PR is merged, if necessary. This will help us keep the docs up to date.

@codecov
Copy link

codecov bot commented Feb 28, 2023

Codecov Report

Merging #8266 (02868df) into main (ffc3727) will decrease coverage by 0.38%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8266      +/-   ##
==========================================
- Coverage   68.10%   67.72%   -0.38%     
==========================================
  Files         621      621              
  Lines       99312    99312              
==========================================
- Hits        67635    67259     -376     
- Misses      31677    32053     +376     
Impacted Files Coverage Δ
crates/nu-command/src/network/http/delete.rs 66.66% <0.00%> (ø)
crates/nu-command/src/network/http/head.rs 68.69% <0.00%> (ø)
crates/nu-command/src/network/http/patch.rs 64.90% <0.00%> (ø)
crates/nu-command/src/network/http/post.rs 64.90% <0.00%> (ø)
crates/nu-command/src/network/http/put.rs 64.90% <0.00%> (ø)
crates/nu-color-config/src/nu_style.rs 9.31% <0.00%> (-70.92%) ⬇️
crates/nu-parser/src/lite_parser.rs 67.18% <0.00%> (-2.17%) ⬇️
crates/nu-parser/src/parser.rs 82.65% <0.00%> (+0.07%) ⬆️

@fdncred
Copy link
Collaborator

fdncred commented Feb 28, 2023

Thanks for cleaning this up.

@fdncred fdncred merged commit 50f1e33 into nushell:main Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants