Uniformize usage() and extra_usage() message ending for commands helper. #8268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #8268 +/- ##
==========================================
- Coverage 68.10% 67.72% -0.38%
==========================================
Files 621 621
Lines 99312 99312
==========================================
- Hits 67635 67262 -373
- Misses 31677 32050 +373
|
sholderbach
reviewed
Feb 28, 2023
|
I’m opened to any suggestions. If you have something in mind that could help to uniformize the descriptions while also resolving the issue you mentioned with the column, please let me know. |
|
wow! what a pain to do all this. thanks so much! |
rgwood
approved these changes
Mar 1, 2023
drbrain
added a commit
to drbrain/nushell
that referenced
this pull request
Dec 10, 2023
Add a test to ensure that commands won't regress Part of nushell#5066 See also nushell#8268
drbrain
added a commit
to drbrain/nushell
that referenced
this pull request
Dec 10, 2023
Add a test to ensure that commands won't regress Part of nushell#5066 See also nushell#8268
fdncred
pushed a commit
that referenced
this pull request
Dec 10, 2023
# Description This repeats #8268 to make all command usage strings start with an uppercase letter and end with a period per #5056 Adds a test to ensure that commands won't regress Part of #5066 # User-Facing Changes Command usage is now consistent # Tests + Formatting - 🟢 `toolkit fmt` - 🟢 `toolkit clippy` - 🟢 `toolkit test` - 🟢 `toolkit test stdlib` # After Submitting Automatic documentation updates
hardfau1t
pushed a commit
to hardfau1t/nushell
that referenced
this pull request
Dec 14, 2023
…1278) # Description This repeats nushell#8268 to make all command usage strings start with an uppercase letter and end with a period per nushell#5056 Adds a test to ensure that commands won't regress Part of nushell#5066 # User-Facing Changes Command usage is now consistent # Tests + Formatting - 🟢 `toolkit fmt` - 🟢 `toolkit clippy` - 🟢 `toolkit test` - 🟢 `toolkit test stdlib` # After Submitting Automatic documentation updates
dmatos2012
pushed a commit
to dmatos2012/nushell
that referenced
this pull request
Feb 20, 2024
…1278) # Description This repeats nushell#8268 to make all command usage strings start with an uppercase letter and end with a period per nushell#5056 Adds a test to ensure that commands won't regress Part of nushell#5066 # User-Facing Changes Command usage is now consistent # Tests + Formatting - 🟢 `toolkit fmt` - 🟢 `toolkit clippy` - 🟢 `toolkit test` - 🟢 `toolkit test stdlib` # After Submitting Automatic documentation updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Working on uniformizing the ending messages regarding methods usage() and extra_usage(). This is related to the issue #5066 after discussing it with @jntrnr
User-Facing Changes
None.
Tests + Formatting
Don't forget to add tests that cover your changes.
Make sure you've run and fixed any issues with these commands:
cargo fmt --all -- --checkto check standard code formatting (cargo fmt --allapplies these changes)cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collectto check that you're using the standard code stylecargo test --workspaceto check that all tests passAfter Submitting
If your PR had any user-facing changes, update the documentation after the PR is merged, if necessary. This will help us keep the docs up to date.