WIP fetch command - support reading url from variable #886
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when passing a variable,
$it
, to thefetch
command, it breaks with a parse error because it is expecting a Path where it finds a String value. This PR adds support to create aPathBuf
from aPrimitive::String
so values can be read from tables and passed into fetch.Having this feature is helpful when calling APIs with long query strings.
Example
Example json file, but could be data from anywhere.
The following works as if we directly called
fetch https://book.nushell.sh
open test_file.json | get url | fetch $it
TODO