Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow find command to look in specified columns only #8937

Merged
merged 3 commits into from Apr 20, 2023

Conversation

fdncred
Copy link
Collaborator

@fdncred fdncred commented Apr 19, 2023

Description

This PR allows the find command to search in specific columns using --columns [col1 col2 col3]. This is really meant to help with the help command in the std.nu.

There are a few more things I want to look at so this is a draft for now.

  • add example
  • look at regex part

User-Facing Changes

Tests + Formatting

After Submitting

@fdncred fdncred marked this pull request as draft April 19, 2023 21:29
@codecov
Copy link

codecov bot commented Apr 19, 2023

Codecov Report

Merging #8937 (e904952) into main (29256b1) will increase coverage by 0.36%.
The diff coverage is 92.59%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8937      +/-   ##
==========================================
+ Coverage   68.18%   68.55%   +0.36%     
==========================================
  Files         636      636              
  Lines      101704   101755      +51     
==========================================
+ Hits        69350    69754     +404     
+ Misses      32354    32001     -353     
Impacted Files Coverage Δ
crates/nu-command/src/filters/find.rs 79.02% <92.59%> (+1.99%) ⬆️

... and 10 files with indirect coverage changes

@fdncred fdncred marked this pull request as ready for review April 20, 2023 13:13
@fdncred fdncred merged commit 393f424 into nushell:main Apr 20, 2023
18 checks passed
@fdncred fdncred deleted the find_in_specific_columns branch April 20, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant