Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing file names from rm errors #9120

Merged
merged 7 commits into from
Jun 18, 2023

Merge branch 'nushell:main' into 9004-rm-filename-missing

79b6fd4
Select commit
Failed to load commit list.
Merged

Fix missing file names from rm errors #9120

Merge branch 'nushell:main' into 9004-rm-filename-missing
79b6fd4
Select commit
Failed to load commit list.
Codecov / codecov/project succeeded May 11, 2023 in 0s

68.91% (target 55.00%)

View this Pull Request on Codecov

68.91% (target 55.00%)

Details

Codecov Report

Merging #9120 (79b6fd4) into main (39e51f1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #9120   +/-   ##
=======================================
  Coverage   68.91%   68.91%           
=======================================
  Files         641      641           
  Lines      102337   102331    -6     
=======================================
- Hits        70522    70518    -4     
+ Misses      31815    31813    -2     
Impacted Files Coverage Δ
crates/nu-protocol/src/shell_error.rs 30.76% <ø> (ø)
crates/nu-command/src/filesystem/rm.rs 79.87% <100.00%> (+2.59%) ⬆️

... and 2 files with indirect coverage changes