Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aarch64-pc-windows-msvc building target for nu binaries #9162

Merged
merged 2 commits into from May 20, 2023

Conversation

hustcer
Copy link
Contributor

@hustcer hustcer commented May 11, 2023

Description

  1. Add aarch64-pc-windows-msvc building target for nu binaries
  2. Bump nushell version for the binary release script

User-Facing Changes

Add two more packages:

  1. aarch64-pc-windows-msvc.zip
  2. aarch64-pc-windows-msvc.msi

Tests + Formatting

Release workflow test: https://github.com/hustcer/nu-release/actions/runs/4943037199
Create release draft test: https://github.com/hustcer/nu-release/releases/tag/v0.79.2

@hustcer hustcer changed the title feature/release-win-arm64 Add aarch64-pc-windows-msvc building target for nu binaries May 11, 2023
@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Merging #9162 (f41f69e) into main (43a3983) will increase coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #9162      +/-   ##
==========================================
+ Coverage   68.90%   68.91%   +0.01%     
==========================================
  Files         641      641              
  Lines      102337   102337              
==========================================
+ Hits        70516    70529      +13     
+ Misses      31821    31808      -13     

see 2 files with indirect coverage changes

@hustcer hustcer merged commit 4b9f479 into nushell:main May 20, 2023
18 checks passed
@hustcer hustcer deleted the feature/release-win-arm64 branch May 20, 2023 12:50
@fdncred
Copy link
Collaborator

fdncred commented Jun 10, 2023

This PR broke the winget release because we now have 2 msi files and therefore we need 2 winget releases. I guess you can only have 1 msi per winget_pkg? See #9322 and #8070

@hustcer
Copy link
Contributor Author

hustcer commented Jun 10, 2023

I see, I will try to fix it before the next release

@fdncred
Copy link
Collaborator

fdncred commented Jun 10, 2023

@hustcer Thanks. One of the people who helped create the winget release thinks it may be fine, it's just that we've never released 2 msi files before. You should read the threads i posted to see if something needs to be done or not. Here's the current winget release for reference on what it should look like microsoft/winget-pkgs#109445

@hustcer
Copy link
Contributor Author

hustcer commented Jun 11, 2023

Once the PR is merged, the action should now work with the next releases. It checks if the installer URL count match with the previous release.

Yeah, I agree with @sitiom https://github.com/nushell/nushell/actions/runs/5226501091/jobs/9437222070 failed because it ran java -jar komac.jar update with two msi urls and we don't have aach64 msi before. It should work after microsoft/winget-pkgs#109445 been merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants