Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the span of the global std help item #9184

Merged
merged 1 commit into from May 12, 2023

Conversation

amtoine
Copy link
Member

@amtoine amtoine commented May 12, 2023

related to

Description

i actually forgot to fix in #9039 the new "item" introduced by #9101... πŸ‘€
there it is πŸ˜‡

User-facing changes

going from

> std help git-commiteuwqi
Help pages from external command git-commiteuwqi:
No manual entry for git-commiteuwqi
Error:
  Γ— std::help::item_not_found
     ╭─[help:721:1]
 721 β”‚
 722 β”‚     let item = ($item | str join " ")
     Β·     ─┬─
     Β·      ╰── item not found
 723 β”‚
     ╰────

to

> std help git-commiteuwqi
Help pages from external command git-commiteuwqi:
No manual entry for git-commiteuwqi
Error:
  Γ— std::help::item_not_found
   ╭─[entry #2:1:1]
 1 β”‚ std help git-commiteuwqi
   Β·          ───────┬───────
   Β·                 ╰── item not found
   ╰────

Tests + Formatting

  • 🟒 toolkit fmt
  • 🟒 toolkit clippy
  • ⚫ toolkit test
  • ⚫ toolkit test stdlib

After Submitting

$nothing

@amtoine amtoine added the std-library Defining and improving the standard library written in nu and the core Rust ccommands label May 12, 2023
@amtoine amtoine self-assigned this May 12, 2023
@codecov
Copy link

codecov bot commented May 12, 2023

Codecov Report

Merging #9184 (b62fbdb) into main (9ebb61f) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #9184   +/-   ##
=======================================
  Coverage   68.99%   68.99%           
=======================================
  Files         641      641           
  Lines      102467   102467           
=======================================
  Hits        70692    70692           
  Misses      31775    31775           

see 2 files with indirect coverage changes

@amtoine amtoine merged commit 92c1051 into nushell:main May 12, 2023
18 checks passed
@amtoine amtoine deleted the fix/stdlib/help-span--again branch May 12, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
std-library Defining and improving the standard library written in nu and the core Rust ccommands
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant