Pull in the latest features from reedline #9207
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes the changes for history exclusion only on the reedline side, needs explicit enabling on the consumer side. Also changes the behavior of keybindings with modifiers that previously where unsupported. Now it is possible to bind keys without a modifier or that use Ctrl+Alt in directly inserting modes.
This feature was introduced by: nushell/reedline#566 Enabled and set the prefix to a hard-coded space
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #9207 +/- ##
==========================================
- Coverage 68.92% 68.91% -0.01%
==========================================
Files 635 635
Lines 102041 102042 +1
==========================================
- Hits 70332 70327 -5
- Misses 31709 31715 +6
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We missed to upgrade to the latest features of reedline and only upgraded publicly to the changes that fix the bracketed paste on the reedline side.
This includes a semantic change in the core of reedline on how bindings are processed and also a bigger change to the history to support ignoring of entries for the history.
If you just release the current reedline
mainwe would not enable history exclusion. This requires the second commit of this PR.Commits
We may want to only merge the first (Doing a branched of release of just what we already pinned in
Cargo.lockseems like extraordinary effort)User-Facing Changes
If we land the first commit will change the behavior of keybindings that were previously ignored as they tried to capture a potentially printable character that was directly inserted into the buffer. Now more bindings are possible:
vi_insertandemacs).Ctrl-Altcombinations that were previously ignored to make sureAltGrcharacters (found on many European keyboards) can properly be inserted.If we land the second commit before the release will ignore all manually entered lines starting with the space from addition to the history. You can still recall the last entry by pressing up arrow once even if it started with a space but it will not be stored in the history file.
Tests + Formatting
The newest reedline behavior wasn't really tested by a wider base of users in the full nushell context.
After Submitting